-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clean-up button to control the remote work directory clean #497
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #497 +/- ##
===========================================
+ Coverage 55.82% 77.29% +21.47%
===========================================
Files 27 44 +17
Lines 2370 3127 +757
===========================================
+ Hits 1323 2417 +1094
+ Misses 1047 710 -337
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I didn't expect the space are so large. I intended to use the I opened an issue for it #499 |
@mikibonacci By default the check box is always on ? This could be problematic if an user missed this and wanted to do postprocessing with some files not saved |
Then, it will be an "advanced" user and he is supposed to go to the advance setting and un-tick it I assume? |
As we discussed in the last AiiDAlab meeting, we agree that the workchain should not be cleaned by default. I'll open a PR for it after. |
fixes #370